[pull] master from ruby:master#778
Merged
pull[bot] merged 2 commits intoturkdevops:masterfrom Feb 14, 2026
Merged
Conversation
After GH-15911, we largely apply the same treatment to these two variants everywhere. In `type_specialize`, there are two ~100 LOC match arms that shared 90% of the code. Unifying these allowed the code to be shared more easily. --- **Note:** In the interest of preserving existing semantics and keeping the diff small for this initial PR, `YARVINSN_send` can currently produce: ```rs Insn::Send { blockiseq: Some(null_ptr), .. } ``` Either way, that can be done in a follow-up PR. --- Follow-up tasks: 1. Unify `reduce_send_to_ccall`/`reduce_send_without_block_to_ccall` 2. Address the `Some(null_ptr)` situation above (discussed on PR) 3. Rename/merge the stats/counters/fallback reasons, if desired Partially addresses Shopify#941 (TODO: `optimize_c_calls`) [alan: rewrote commit message] Reviewed-by: Alan Wu <XrXr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )