ABN-443/fix: surcharge on invoice/credit-memo PDF + shipping before tax#208
Merged
Merged
Conversation
…efore tax The surcharge never appeared on PDFs because it was registered under PDF item-renderers, not totals. Register it as a totals model via etc/pdf.xml (sort_order 280) so the renderer prints the NET surcharge directly above the Tax line. Also move Shipping & Handling ahead of Tax (sort_order 250 vs tax 300) — shipping is part of the tax base and the on-screen totals already show it first. Drop the dead di.xml item-renderer registration; sequence after Magento_Tax for a deterministic pdf.xml merge; brand-neutral fallback label. Refs ABN-443 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoice/credit-memo PDF fixes:
<model>(etc/pdf.xml, sort_order 280) → prints the NET surcharge directly above the Tax line.Also: dropped the dead di.xml item-renderer entry, added Magento_Tax to module sequence (deterministic pdf.xml merge), brand-neutral fallback label. PHPUnit 153 green. Verify by rendering an invoice + credit-memo PDF. Refs ABN-443