Conversation
|
Thanks for the PR, @IVSOP! This helps me understand the feature better. Thoughts @lgalabru and @IVSOP on this PR as-is vs two cheatcodes:
This would make each endpoint more "full-featured", like |
|
I didn't split the endpoint because the logic is the exact same (just write a key into |
|
What would be the next steps on this PR @IVSOP @MicaiahReid ? |
ddbaab6 to
137ac68
Compare
|
I've changed the endpoint from In short, the plugins use a byte offset system. An offset of I'd like to hear your thoughts before I implement a similar endpoint for core collections and not just assets. {
"jsonrpc": "2.0",
"id": 1,
"method": "surfnet_updateCoreAsset",
"params": [
"2mNhQ5GHcn2y4CtR32LSKvhNzRumeVH1PMkFdACwqtNz",
{
"owner": "<<<some new owner pubkey>>>",
"name": "some new name",
}
]
}You can test this for yourself using the NFT viewer I provided in the top message and using the localhost mode. |
Adds feature described in #391, allowing changing ownership of a core NFT and authority of a core collection, through the new
surfnet_stealCoreendpoint.Example request, stealing this random core NFT
{ "jsonrpc": "2.0", "id": 1, "method": "surfnet_stealCore", "params": [ "2mNhQ5GHcn2y4CtR32LSKvhNzRumeVH1PMkFdACwqtNz", "<key of the new owner>" ] }