Do models.Model adjustments from get_metaclass_hook - #2322
Merged
Conversation
The called hook expects/wants the class body analyzed, but the `get_customize_class_mro_hook` hook, that it was previously called from, invokes the hook before the class body has been analyzed..
sobolevn
approved these changes
Aug 6, 2024
sobolevn
left a comment
Member
There was a problem hiding this comment.
Thanks! I think that we didn't have this hook back in the days of the original code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The called hook expects/wants the class body analyzed, but the
get_customize_class_mro_hookhook, that it was previously called from, invokes the hook before the class body has been analyzed..Docs: https://mypy.readthedocs.io/en/stable/extending_mypy.html#current-list-of-plugin-hooks
Related issues
objectsattribute fromModelin plugin #2280