Add overloads for assertTemplateUsed and assertTemplateNotUsed - #3564
Open
brianhelba wants to merge 1 commit into
Open
Add overloads for assertTemplateUsed and assertTemplateNotUsed#3564brianhelba wants to merge 1 commit into
assertTemplateUsed and assertTemplateNotUsed#3564brianhelba wants to merge 1 commit into
Conversation
The return type of these can actually be determined more precisely, given the argument types. Follows https://github.com/pytest-dev/pytest-django/pull/12781
sobolevn
reviewed
Aug 5, 2026
| def test_assert_template_used(self) -> None: | ||
| response = self.client.get("/url") | ||
| assert_type(self.assertTemplateUsed(response, "template.html"), None) | ||
| assert_type(self.assertTemplateUsed("template.html"), _AssertTemplateUsedContext) |
Member
There was a problem hiding this comment.
It would better be:
with self.assertTemplateUsed("template.html") as ctx:
assert_type(ctx, ...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return type of these can actually be determined more precisely, given the argument types.
Follows https://github.com/pytest-dev/pytest-django/pull/12781
AI Policy