Closed
Conversation
Author
|
I think the CI failure might be an unrelated issue (flakiness?) |
Contributor
|
Could be nice to have this as an instance method on |
Contributor
|
What if we use trait IOLocal[A] {
def scope[A](value: A): Resource[IO, A] =
Resource.make(local.getAndSet(value))(local.set)
}That way, the scope can be managed for val local: IOLocal[String] = ???
val stream: fs2.Stream[IO, ...] = fs2.Stream.resource(local.scope("my-scope")).evalMap(_ => ???)
val resource: Resource[IO, ...] = local.scope("external").flatMap(_ => ??? >> local.scope("internal"))
val io: IO[...] = local.scope("my-scope").use(_ => ???) |
djspiewak
requested changes
Sep 19, 2022
Member
djspiewak
left a comment
There was a problem hiding this comment.
Agreed this should probably be Resource, and also would offer better ergonomics as an instance method. Overall though I like this concept!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought it could be useful to have a way to update the value of an
IOLocalwithin the scope of some taskIO[A]Motivation was being able to set log context here: typelevel/log4cats#676