feat: sbt-2 migration prototype with ProjectMatrixWrapper and thin client#872
Open
the-ivii wants to merge 1 commit intotypelevel:mainfrom
Open
feat: sbt-2 migration prototype with ProjectMatrixWrapper and thin client#872the-ivii wants to merge 1 commit intotypelevel:mainfrom
the-ivii wants to merge 1 commit intotypelevel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbt 2 & CI Generation: upgrades the build to sbt 2.0.0-M2 and updates GenerativePlugin to use the thin client directly, removing the old ++ ${{ matrix.scala }} string injection
Backwards-Compatible Abstraction: adds a ProjectMatrixWrapper to replace the Scala 2 macro. This shows that we can map tlCrossRootProject directly to sbt 2's ProjectMatrix without disrupting downstream users
current status is as expected, full compilation is on hold while we wait for upstream plugins, like sbt-scalajs-crossproject, to release their sbt 2 milestones. However, this successfully confirms our core rewrite strategy