Skip to content

greeter-socket: accept reconnect when previous greeter is stale - #488

Open
Franklin-Qi wants to merge 1 commit into
ubuntu:mainfrom
Franklin-Qi:fix/472-session-greeter-reconnect-race
Open

Franklin-Qi wants to merge 1 commit into
ubuntu:mainfrom
Franklin-Qi:fix/472-session-greeter-reconnect-race

Conversation

@Franklin-Qi

Copy link
Copy Markdown

test-session-greeter-reconnect could fail intermittently when a new in-session greeter connected before the previous connection's HUP cleared the active greeter, causing the daemon to close the socket ("Connection reset by peer"). Replace a HUP/ERR stale greeter on accept, and treat G_IO_HUP with other conditions in greeter read_cb.

Fixes #472

test-session-greeter-reconnect could fail intermittently when a new
in-session greeter connected before the previous connection's HUP
cleared the active greeter, causing the daemon to close the socket
("Connection reset by peer"). Replace a HUP/ERR stale greeter on accept,
and treat G_IO_HUP with other conditions in greeter read_cb.

Fixes ubuntu#472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non-deterministic test-session-greeter-reconnect test failure (~10% fail rate)

1 participant