Skip to content

session-child: use _exit in SIGTERM handler (#484) #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Franklin-Qi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

session-child: use _exit in SIGTERM handler (#484) #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/session-child.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,14 @@ pam_conv_cb (int msg_length, const struct pam_message **msg, struct pam_response
static void
signal_cb (int signum)
{
/* Pass on signal to child, otherwise just quit */
/* Pass on signal to child, otherwise just quit.
* Use _exit: exit() is not async-signal-safe and can deadlock in malloc
* if SIGTERM arrives while the main thread holds the arena lock (#484).
*/
if (child_pid > 0)
kill (child_pid, signum);
else
exit (EXIT_SUCCESS);
_exit (EXIT_SUCCESS);
}

static XAuthority *
Expand Down