Feat/add pypi#124
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
|
@k-burt-uch |
700d7b7 to
39d79e3
Compare
39d79e3 to
d67ff1a
Compare
ee6a9b9 to
89c1664
Compare
Looks like poetry 2.3.0 is causing some havoc with Python 3.9 Working on it. |
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "data-simulator" | |||
There was a problem hiding this comment.
If we're pushing to PyPI, I would prefer to prefix this with gen3-. Does that break a ton of things?
There was a problem hiding this comment.
I would also propose that perhaps instead of including as a separate package entirely, we include this as an optional install of the Gen3 Python SDK/CLI pip install gen3[data-simulator] and expose the CLI similar to how we do pypfb. This could be a secondary/in-addition-to having it alone on pypi though
There was a problem hiding this comment.
Created https://ctds-planx.atlassian.net/browse/PD-119 to add to the gen3sdk. Fixing issues caused by the rename
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes