Skip to content

Feat/add pypi#124

Open
k-burt-uch wants to merge 2 commits into
masterfrom
feat/add-pypi
Open

Feat/add pypi#124
k-burt-uch wants to merge 2 commits into
masterfrom
feat/add-pypi

Conversation

@k-burt-uch

Copy link
Copy Markdown

Link to JIRA ticket if there is one:

New Features

  • Add pypi

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

nss10
nss10 previously approved these changes Feb 3, 2026
@nss10

nss10 commented Feb 3, 2026

Copy link
Copy Markdown

@k-burt-uch
I know this isn’t strictly part of your task, but could you take a quick look at why the unit tests are failing? It looks like the failure is happening during poetry install, so I’m wondering if it’s a small fix.
If it turns out to be more than that, let me know — I can pick it up as an on-call task.

@k-burt-uch k-burt-uch force-pushed the feat/add-pypi branch 4 times, most recently from 700d7b7 to 39d79e3 Compare February 3, 2026 18:23
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
filepath passed error skipped SUBTOTAL
tests/test_graph_submit_and_query.py 0 14 0 14
tests/test_data_upload.py 8 0 1 9
TOTAL 8 14 1 23

Please find the detailed integration test report here

Please find the Github Action logs here

@k-burt-uch

Copy link
Copy Markdown
Author

@k-burt-uch I know this isn’t strictly part of your task, but could you take a quick look at why the unit tests are failing? It looks like the failure is happening during poetry install, so I’m wondering if it’s a small fix. If it turns out to be more than that, let me know — I can pick it up as an on-call task.

Looks like poetry 2.3.0 is causing some havoc with Python 3.9

Working on it.

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
filepath passed error skipped SUBTOTAL
tests/test_graph_submit_and_query.py 13 2 1 16
tests/test_data_upload.py 8 0 1 9
TOTAL 21 2 2 25

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown
filepath passed skipped SUBTOTAL
tests/test_graph_submit_and_query.py 13 1 14
TOTAL 13 1 14

Please find the detailed integration test report here

Please find the Github Action logs here

Comment thread pyproject.toml Outdated
@@ -1,6 +1,6 @@
[tool.poetry]
name = "data-simulator"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're pushing to PyPI, I would prefer to prefix this with gen3-. Does that break a ton of things?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also propose that perhaps instead of including as a separate package entirely, we include this as an optional install of the Gen3 Python SDK/CLI pip install gen3[data-simulator] and expose the CLI similar to how we do pypfb. This could be a secondary/in-addition-to having it alone on pypi though

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created https://ctds-planx.atlassian.net/browse/PD-119 to add to the gen3sdk. Fixing issues caused by the rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants