Skip to content

add content-disposition attachment to trigger direct download #426 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UcDust wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

add content-disposition attachment to trigger direct download #426 #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c87c93
add content-disposition attachment to trigger direct download #426
UcDust Apr 14, 2026
ddfd953
remove query params from filename in filename of header
UcDust Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions services/binary-mirror/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ app.get('*', async (req, res) => {
return;
}

if( req.query.download ) {
res.setHeader('Content-Disposition', `attachment; filename="${path.basename(message.path.split('?')[0])}"`);
}

try {
console.log('File request: '+message.path+' with ETag:', etag);
await streamFile(message.path, etag, res);
Expand Down
15 changes: 15 additions & 0 deletions services/fin/ucd-lib-client/client/public/elements/pages/record/app-media-download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,10 @@ export default class AppMediaDownload extends Mixin(LitElement).with(
return;
}

if( e.currentTarget?.href ) {
e.currentTarget.href = this._appendDownloadParam(e.currentTarget.href);
}

let path = this.rootRecord["@id"].replace(config.fcrepoBasePath, "");
gtag("event", "download", {
event_category: "fullset",
Expand All @@ -524,6 +528,11 @@ export default class AppMediaDownload extends Mixin(LitElement).with(
e.preventDefault();
return;
}

if( e.currentTarget?.href ) {
e.currentTarget.href = this._appendDownloadParam(e.currentTarget.href);
}

let path = this.href.replace(config.fcrepoBasePath, "");

gtag("event", "download", {
Expand All @@ -532,6 +541,12 @@ export default class AppMediaDownload extends Mixin(LitElement).with(
value: 1,
});
}

_appendDownloadParam(url) {
if (!url) return url;
if (url.includes('download=')) return url;
return url + (url.includes('?') ? '&' : '?') + 'download=true';
}
}

customElements.define("app-media-download", AppMediaDownload);