Splits the `EditorDecorator` by ufukty · Pull Request #67 · ufukty/dim

ufukty · 2026-05-20T09:06:20Z

Mainly:

resolves Coupling between document and text editor concerns #66

Additionally:

…corator into document and editor controllers.

… controllers split. simplifies the rest.

…ler.

…e module name conveys the unit name.

…writes the section explains the editor and document controllers for flow.

… text editors appear and disappear. changes to track focus/blur state in more explicit naming `inSessionConfigEdit` insite the editor controllers.

…n before editor controller initialization inside the extension activation.

…order to centralize their registration to Code from previous per-editor way.

…lect state change on split (secondary) editors.

…gnore `settings.json`.

…he config editor.

…nt procedure on initialization.

…itors changed event.

…on type regardless of the rule's tier.

…rs fails to detect editors of configuration file.

…ent miss updating secondary editors and invalidating the match cache.

…e is ongoing config edit session.

…c toggle immediately after new editor appear

…ng the first update.

…to collide using a counter.

…nsion deactivation.

…idate matches.

ufukty added 4 commits May 10, 2026 10:16

src/extension.ts: removes unused.

7cc0c08

diagrams/structure.mmd: changes to reflect the split of the editor de…

2e55aac

…corator into document and editor controllers.

contributing.md: changes the overview section for the editor-document…

1d8f1b9

… controllers split. simplifies the rest.

contributing.md: adds new section for the caching at document control…

b856056

…ler.

ufukty changed the title ~~Splits editor decorator for coupling document and editor concerns~~ Splits the editor decorator up to document and editor controllers May 21, 2026

ufukty added 8 commits May 21, 2026 20:54

src/configManager.ts: changes the Cache.for to accept the direct value

55c97f4

src: splits the EditorDecorator into two classes.

b318133

src/editor.ts: renames file.

8a10d76

src/editor.ts: renames EditorDecorator to Controller for the split.

06ac243

src/editors.ts: renames file.

4fec0fc

src/extension.ts: fixes references to editors.Controller.

d5fc7c0

src/documents.ts: renames DocumentController to Controller, as th…

03328e8

…e module name conveys the unit name.

src/extension.ts: changes the import style for consistency.

63af4b1

ufukty changed the title ~~Splits the editor decorator up to document and editor controllers~~ Splits the EditorDecorator May 23, 2026

ufukty added 16 commits May 23, 2026 12:13

contributing.md: adds to explain short-live of editor controllers. re…

8fdd77b

…writes the section explains the editor and document controllers for flow.

contributing.md: punc.

02f9357

src/extension.ts: changes to create and destroy editor controllers as…

dda4de8

… text editors appear and disappear. changes to track focus/blur state in more explicit naming `inSessionConfigEdit` insite the editor controllers.

src/extension.ts: renames to LifecycleController to simplify.

95fcdca

src/editor.ts: removes redundant.

e2a4886

src/extension.ts: fixed the missing document controller initializatio…

fe7e020

…n before editor controller initialization inside the extension activation.

src/extension.ts: refined log messages.

f284d55

src/extension.ts: simplified the even-receiver method names.

42e5611

src/extension.ts: removes redundant.

1d0618c

src/extension.ts: refined log messages.

09e7166

src/models.ts: removes unused.

68b0169

src/configManager.ts: refines logging.

4c3da83

src/configManager.ts: moves in the decoration type creation logic in …

a06dd32

…order to centralize their registration to Code from previous per-editor way.

src/extension.ts: refined logging.

9c1119a

src/editors.ts: removes redundant.

1157c73

src: refined logging with cleaner file path printing.

01a9ec7

ufukty added 16 commits May 24, 2026 23:46

src/extension.ts: fixes the per-doc toggle feature to immediately ref…

58e71fc

…lect state change on split (secondary) editors.

src/extension.ts: changes the document open/close event handlers to i…

82e3dc3

…gnore `settings.json`.

src/extension.ts: fixes the boolean logic used to detect closing of t…

88512d1

…he config editor.

src/extension.ts: changes to perform full visible editors changed eve…

ffe81bc

…nt procedure on initialization.

src/extension.ts: refined logging.

336c349

src/models.ts: writing style.

7498651

src/models.ts: removes unnecessary comment.

6b36f14

src/extension.ts: refines logging on event handler for the visible ed…

7e6cfa0

…itors changed event.

src/editors.ts: fixes the editor controller applies the same decorati…

fb251f4

…on type regardless of the rule's tier.

src/extension.ts: fixes the event handler for change in visible edito…

8be61e0

…rs fails to detect editors of configuration file.

src/extension.ts: fixed the event handler for change in document cont…

bdb9c9c

…ent miss updating secondary editors and invalidating the match cache.

src/editors.ts: fixes the editor controller is initialized as if ther…

59f69f9

…e is ongoing config edit session.

src/extension.ts: fixes the lifecycle controller can't restore per-do…

6b55dd2

…c toggle immediately after new editor appear

src/editors.ts: fixes the editor controller constructor miss scheduli…

e60d160

…ng the first update.

src/extensions.ts: writing style.

d013ec7

src/extension.ts: changes to prevent log names of editor controllers …

43a163e

…to collide using a counter.

ufukty added refactor fix labels May 26, 2026

ufukty added 5 commits May 26, 2026 12:02

src/extension.ts: fixed the registered types are not disposed at exte…

6c7ed23

…nsion deactivation.

src/extension.ts: refined the error logging.

015e6ec

src/extension.ts: fixes the config change event handler doesn't inval…

1151c0d

…idate matches.

changelog.md: adds entry for the next release.

5b5896e

package.json: bumps the embedded version.

779807e

ufukty merged commit 762276d into main May 26, 2026
2 checks passed

ufukty deleted the cl/2 branch May 26, 2026 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Splits the `EditorDecorator`#67

Splits the `EditorDecorator`#67
ufukty merged 49 commits into
mainfrom
cl/2

ufukty commented May 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ufukty commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ufukty commented May 20, 2026 •

edited

Loading