📐 Add blkt and divertor poloidal angles#4207
Draft
chris-ashe wants to merge 17 commits intomainfrom
Draft
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…ations Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…ed by plasma Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…ded by plasma Co-authored-by: Copilot <copilot@github.com>
…plasma Co-authored-by: Copilot <copilot@github.com>
…n structure plot Co-authored-by: Copilot <copilot@github.com>
…for outboard, inboard, and divertor angles Co-authored-by: Copilot <copilot@github.com>
…dal angle Co-authored-by: Copilot <copilot@github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
- Coverage 52.10% 51.99% -0.12%
==========================================
Files 148 148
Lines 30389 30511 +122
==========================================
+ Hits 15835 15863 +28
- Misses 14554 14648 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <copilot@github.com>
… mark it as deprecated Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new calculations and visualizations for the poloidal angles subtended by the outboard and inboard blankets, as well as the divertor, in the plasma cross-section plots. It adds new variables to store these angles and their fractions, integrates their calculation into the blanket and divertor models, and updates plotting and output routines to display these geometric relationships.
The main change is that
f_ster_div_singleis no longer an input and is calculated from the geometry. This is a necessary step in having seperate blankets and divertors as the specific flux to each component can now be calculated so they can have their own cooling requirements.New blanket and divertor angle calculations and variables:
blanket_library.pyanddivertor_variables.pyto store outboard/inboard blanket poloidal angles, their fractions, and divertor poloidal angle.BlanketLibrary, and for the divertor angle in the divertor model, referencing the blanket geometry.Integration into model execution:
hcpb.pyanddivertor.pyto set the new angle variables during model runs, ensuring these values are available for output and further calculations.Enhanced output and visualization:
plot_blkt_structurefunction to display the blanket and divertor angles visually, including annotated arcs, arrows, and info boxes for each angle on the cross-section plot.Data initialization and test updates:
✍🏻 Plotting outputs
Large tokamak
ST
These changes improve the geometric fidelity of the model and enhance the clarity of output visualizations, making it easier to interpret the physical relationships between the plasma, blankets, and divertor.
Checklist
I confirm that I have completed the following checks: