Skip to content

5HNb3hh4eAbqqhdsoeJuw1UFaLix22DtyNfow2mvaBEDHEhs update - #1583

Open
duelwarrior630-crypto wants to merge 1 commit into
unarbos:mainfrom
duelwarrior630-crypto:miner/5HNb3hh4-1778780784
Open

duelwarrior630-crypto wants to merge 1 commit into
unarbos:mainfrom
duelwarrior630-crypto:miner/5HNb3hh4-1778780784

Conversation

@duelwarrior630-crypto

Copy link
Copy Markdown

Summary

Miner submission for Subnet 66.
Hotkey: 5HNb3hh4eAbqqhdsoeJuw1UFaLix22DtyNfow2mvaBEDHEhs
Branch: miner/5HNb3hh4-1778780784 from duelwarrior630-crypto/ninja-miner
Author note: update

Scope

  • Diff size: +50 / -5 (55 changed lines)
  • Functions modified (3): _check_json_syntax_one, _should_skip_patch_path, build_self_check_prompt

@github-actions

Copy link
Copy Markdown

OpenRouter PR Judge

Verdict: FAIL
Model: anthropic/claude-opus-4.7
Threshold: 70

Score Value
Overall 58
Real edit 55
Safety 90
Scope 75
Contract 95

Summary

The PR makes three changes to agent.py: (1) expands the skip-list for patch paths to include more editor/tool artifacts (.swp, .swo, .bak, .DS_Store, .tox, .idea, .vscode, .next, .turbo); (2) adds .dart to the brace-balance suffix set and reorders some entries; (3) adds substantial new prose to SYSTEM_PROMPT (sibling-identifier preservation, task scope lock) and to build_self_check_prompt (undefined-identifier hard stop, deliverable coverage). The path-skip change is a small real mechanism improvement; the bulk of substantive lines are prompt-only additions.

Static Checks

  • No static findings.

Judge Reasons

  • Mechanism change in _should_skip_patch_path is genuine but tiny (~10 lines of meaningful new path filtering).
  • The majority of added lines (~40 of 50) are pure prompt string additions to SYSTEM_PROMPT and build_self_check_prompt; no new control flow, no new gates, no new parsing, no new commands.
  • Prompt additions are advisory text aimed at the inner model (sibling identifiers, scope discipline, deliverable coverage checklist) — these are exactly the prompt-only edits the gate is warned about.
  • No changes to solve() signature, return shape, sampling params, env-var allowlist, or DANGEROUS_PATTERNS; contract preserved.
  • No obfuscation, no network exfil, no secret extraction patterns; readability of base file preserved.

Risks

  • prompt-only tuning: ~80% of substantive lines are prose additions to SYSTEM_PROMPT and the self-check prompt; only the skip-path list is a real mechanism change
  • goodhart (mild): 'DELIVERABLE COVERAGE' checklist added to self-check is the kind of judge-flattering structural prose that may shape patch presentation more than correctness

Required Changes

  • Pair the prompt additions with at least one real mechanical change (e.g., a new gate, parser, verification helper, or context-selection signal) so the PR is not effectively prompt-only.
  • Alternatively, drop the prompt prose and keep just the path-skip expansion as a small focused PR with a coherent one-sentence story.

@unarbos unarbos added the notice: missing-commitment Validator notice that no matching on-chain PR commitment was found. label May 14, 2026
@unarbos

unarbos commented May 14, 2026

Copy link
Copy Markdown
Owner

No posted commitment with the hotkey in the title was found. Please commit on-chain using the exact PR head. For an already-open PR, use:

github-pr:unarbos/ninja#1583@1da5ebedb8a164a331628c92e467e0f0a16c68ee

For pre-PR protection, commit the head before opening the PR with:

github-pr-head:unarbos/ninja@1da5ebedb8a164a331628c92e467e0f0a16c68ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notice: missing-commitment Validator notice that no matching on-chain PR commitment was found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants