Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/confuse/fwup.ex
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ defmodule Confuse.Fwup do

@spec squash([Confuse.Fwup.validation()], String.t() | nil) :: t()
def squash(feature_usages, fwup_version) do
fwup_version = Version.parse!(fwup_version || @absolute_minimum_fwup)
specified_version = if fwup_version, do: Version.parse!(fwup_version), else: nil
parsed_version = specified_version || Version.parse!(@absolute_minimum_fwup)

feature_usages
|> Enum.reduce(%Features{valid?: true}, fn f, acc ->
Expand All @@ -68,7 +69,8 @@ defmodule Confuse.Fwup do
(not f.delta_source_fat_offset? or f.fat_deltas_valid?))
}
end)
|> calculate_version(fwup_version)
|> calculate_version(parsed_version)
|> then(&%{&1 | specified_fwup_version: specified_version})
end

defp calculate_version(features, minimum_version) do
Expand Down
55 changes: 55 additions & 0 deletions test/fwup_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,61 @@ defmodule Confuse.FwupTest do
assert {:error, :enoent} = Confuse.Fwup.get_delta_files(path)
end

test "specified_fwup_version is populated when require-fwup-version is present" do
conf = """
require-fwup-version="2.0.0"

task upgrade.a {
on-resource rootfs.img {
raw_write(0)
}
}
"""

expected_version = Version.parse!("2.0.0")

assert {:ok, %Confuse.Fwup.Features{specified_fwup_version: ^expected_version}} =
Confuse.Fwup.get_feature_usage_from_config(conf)
end

test "specified_fwup_version is nil when require-fwup-version is absent" do
conf = """
task upgrade.a {
on-resource rootfs.img {
raw_write(0)
}
}
"""

assert {:ok, %Confuse.Fwup.Features{specified_fwup_version: nil}} =
Confuse.Fwup.get_feature_usage_from_config(conf)
end

test "specified_fwup_version does not affect computed complete_fwup_version or delta_fwup_version" do
conf = """
require-fwup-version="2.0.0"

task upgrade.a {
on-resource rootfs.img {
delta-source-raw-offset=0
delta-source-raw-count=1
raw_write(0)
}
}
"""

specified_version = Version.parse!("2.0.0")
raw_delta_version = Version.parse!("1.6.0")

assert {:ok,
%Confuse.Fwup.Features{
specified_fwup_version: ^specified_version,
raw_deltas?: true,
delta_fwup_version: ^raw_delta_version
}} =
Confuse.Fwup.get_feature_usage_from_config(conf)
end

test "returns an error when source contains resource missing in target" do
source_conf = """
require-fwup-version="0.5.0"
Expand Down