[giodamelio]

Overview

Unisons LSP is currently accepting on the first connection per run. Even after that connection is finished it won't accept any new connections. It looks like it was #6196 (fe8c4d6) when doing a fix for an unrelated bug on Windows.

This just wraps the code that accepts the TCP connections in a forever so we keep accepting connections for the remainder of the programs life.

Implementation approach and notes

Not much there really.

Interesting/controversial decisions

Include anything that you thought twice about, debated, chose arbitrarily, etc.
What could have been done differently, but wasn't? And why?

Test coverage

• Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?

  • No, there aren't any existing harnesses for the LSP over TCP as far as I can tell.

• Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?

  • Ya a test suite to stop other regressions like this seems like a great idea. I'm not farmiliar enough with this codebase to do that though.

• If you only tested by hand, because that's all that's practical to do for this change, mention that. Include screenshots.

  • Not much to screenshot really, just try connecting to the LSP more then once with a single UCM session. I just repeatedly opened and closed my editor. Before it only worked the first time, and with this code it keeps working.

Loose ends

• I'm unable to test this on Windows. I don't have any reason to believe this would break it, but would love to be sure.

Final checklist

• Choose your PR title well: Your pull request title is what's used to create release notes, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.
• Update your PR description if the specifics of the PR have changed over time.
• Include transcripts or screenshots that demonstrate the changed behavior.
• If you changed .cabal files, make sure the package.yaml files are up-to-date instead.

[giodamelio]

Thanks for getting this across the line!

[pchiusano]

Thank you!