Skip to content

Make the shebang in various bash scripts more portable - #6324

Merged
pchiusano merged 6 commits into
unisonweb:trunkfrom
fpringle:pre-push-hook-shebang
Nov 11, 2026
Merged

pchiusano merged 6 commits into
unisonweb:trunkfrom
fpringle:pre-push-hook-shebang

Conversation

@fpringle

Copy link
Copy Markdown
Contributor

Overview

scripts/hooks/pre-push.bash and other bash scripts had a #!/bin/bash shebang instead of #!/usr/bin/env bash. /bin/bash is less portable, for example it doesn't exist on NixOS.

Implementation approach and notes

Doesn't change the Haskell codebase at all.

Interesting/controversial decisions

None

Test coverage

  • If you only tested by hand, because that's all that's practical to do for this change, mention that. Include screenshots.

Before:
image

After:
image

Loose ends

None.

Final checklist

  • Choose your PR title well: Your pull request title is what's used to create release notes, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.
  • Update your PR description if the specifics of the PR have changed over time.
  • Include transcripts or screenshots that demonstrate the changed behavior.
  • If you changed .cabal files, make sure the package.yaml files are up-to-date instead.

@fpringle
fpringle requested a review from a team as a code owner October 26, 2026 21:49
pchiusano added a commit to giodamelio/unison that referenced this pull request Nov 10, 2026
pchiusano added a commit to fpringle/unison that referenced this pull request Nov 10, 2026
@pchiusano
pchiusano added this pull request to the merge queue Nov 10, 2026
@github-actions

Copy link
Copy Markdown

🤖 The merge queue's full run failed, which removed this pull request from the queue: https://github.com/unisonweb/unison/actions/runs/42817907157

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 10, 2026
@pchiusano
pchiusano added this pull request to the merge queue Nov 10, 2026
@pchiusano

Copy link
Copy Markdown
Member

Full CI failed due to flaky windows test, which I'll fix separately, will try again.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 10, 2026
# Conflicts:
#	.github/workflows/proofs/transcripts/8d05120a4e366f177c0f201787c24cde07eac2d4c7eb7f1a7b543b3e861cdb36.txt
@pchiusano
pchiusano added this pull request to the merge queue Nov 10, 2026
Merged via the queue into unisonweb:trunk with commit edcebc8 Nov 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants