Repository navigation
File permission builtins - #6329
Merged
Merged
Conversation
fpringle
force-pushed
the
file-permission-builtins
branch
2 times, most recently
from
November 3, 2026 17:20
e76eba0 to
cc1b413
Compare
fpringle
marked this pull request as ready for review
November 3, 2026 17:23
fpringle
force-pushed
the
file-permission-builtins
branch
from
November 4, 2026 10:22
cc1b413 to
921f273
Compare
…rom trunk, regenerated next)
… and unisonweb#6329, so they merge in any order
pchiusano
added a commit
to fpringle/unison
that referenced
this pull request
Nov 10, 2026
… and unisonweb#6329, so they merge in any order
pchiusano
added a commit
to giodamelio/unison
that referenced
this pull request
Nov 10, 2026
… and unisonweb#6329, so they merge in any order
The tests were in a contribution to @unison/runtime-tests on Share, so CI and interpreter-tests.sh pointed at that contribution's branch. They are now a section of the io transcript, and runtime-tests is back to releases/0.0.6.
# Conflicts: # .github/workflows/proofs/formatting/1b278333198ba9d36ee67e5f2364b6a354792d8c6fac6e0a686b6a1867c02d5f.txt # .github/workflows/proofs/tests/995681c40e02cc2aae528aa0d8a3eef52a011700955ef92dda6bb385c45dcbc8.txt # .github/workflows/proofs/transcripts/e814eb752b0a53d3cdb326c7d28c24260a95390af6acea51b3a7e85a0feb1511.txt
Member
|
Thanks! I moved the tests to io.md transcript in this repo. It makes things simpler, like we don't have to coordinate a release along with merging the PR. I'd use the share project for things that are more complicated or difficult to test without more dependencies. |
|
🤖 The merge queue's full run failed, which removed this pull request from the queue: https://github.com/unisonweb/unison/actions/runs/42939696987 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2026
pchiusano
added a commit
to fpringle/unison
that referenced
this pull request
Nov 11, 2026
On Linux arm64 the bfd linker works around Cortex-A53 erratum 843419 by moving an instruction after an adrp at page offset 0xff8/0xffc into a veneer (e843419@...) and branching there and back. Decoding stopped at the branch into the veneer, and the sweep of fixed code labels only targets with info tables, so the rest of the block was never decoded. The veneer's branch pins the block, so it stayed put with stale references while what it pointed at moved: a minified unisonrt crashed with the JIT on once unisonweb#6329 moved a veneer into Deque code that hello world runs. The target of a veneer's branch is now a label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements built-ins to get and set file permissions, which closes #2790.
New built-ins:
These are then wrapped by the following functions I've added to base here:
Implementation approach and notes
The approach more or less follows the guide here.
getFilePermissions.impl.v1andsetFilePermissions.impl.v1are declared as built-ins, and the haskellPermissiontype is marshalled to/from a(Bool, Bool, Bool, Bool)tuple.Test coverage
I added tests in the
runtime-testsproject here.