Generate Equatable conformance for empty FlagContainers#141
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📒 Description
We currently skip generating
Equatableconformance inside@FlagContainerif the declaration is empty (has no stored properties). This is different from the synthesised conformance toEquatablethat the compiler generates, as described in SE-0185:Currently, this means empty
@FlagContainers that appear any where in a flag hierarchy breaks generated Equatable conformance for the entire hierarchy.This PR updates
@FlagContainerto generate Equatable conformance inline with the behaviour described in SE-0185.🗳 Test Plan
Covered by unit tests and compilation tests.