Merged
Conversation
- fix authorize method trying to create payment method twice.
There was a problem hiding this comment.
Pull Request Overview
This PR implements code style improvements based on SonarQube findings and introduces support for Wero payment method including its related models and test coverage.
- Removes unnecessary public modifiers from test class and method declarations (JUnit 5 package visibility)
- Replaces wildcard imports with explicit import statements for better code clarity
- Adds Wero payment type support with EventDependentPayment configuration and comprehensive test coverage
Reviewed Changes
Copilot reviewed 81 out of 81 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Test classes (multiple) | Removed public modifiers from test classes and methods, replaced wildcard imports with explicit imports |
| WeroTest.java | Added comprehensive test coverage for new Wero payment type including charge, authorize, and additional transaction data scenarios |
| AdditionalTransactionDataWeroTest.java | Added unit tests for Wero-specific additional transaction data serialization and deserialization |
| PaypageV2Test.java | Extended PaypageV2 tests to include Wero payment method configurations with EventDependentPayment support |
| ApiConfigTest.java | Updated test base URL for paypage service from unzer.io to unzer.com |
| TokenServiceTest.java | Moved from service package to integration package |
| AbstractPaymentTest.java | Updated test customer data (email and shipping address) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/test/java/com/unzer/payment/integration/paymenttypes/KlarnaTest.java
Show resolved
Hide resolved
sixer1182
requested changes
Sep 19, 2025
Member
There was a problem hiding this comment.
Please check the following:
- My comments
- Comments by Copilot
- failing tests
To avoid extensive and unrelated changes in the same branch we should next time create a second task and branch e.g. for the test updates in this case. This was really hard to review.
src/test/java/com/unzer/payment/integration/paymenttypes/WeroTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/unzer/payment/integration/paymenttypes/OpenBankingTest.java
Show resolved
Hide resolved
sixer1182
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also inclueds: