Conversation
|
🚀 Preview has been deployed.
|
deb72f6 to
f8ee9c1
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the KYC email fixture documentation to clarify that the +kyc fixture should be placed at the end of the email's username portion (before the @ symbol) to avoid collisions with other email fixtures.
Key changes:
- Updated documentation to specify
+kycplacement at the end of the email username - Added additional example (
user+kyc+abc@domain.com) to demonstrate the correct pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
**Must** now be at the end of the email's username to work correctly.
3118106 to
e671dde
Compare
jackmurdoch
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Email fixture must now be at the end of the email's username to work correctly.
This is done to avoid collisions.
Related issues
https://uphold.atlassian.net/browse/SWY-3557