Repository navigation
Conversation
Lua scripts are prefixed with `#!lua flags=allow-key-locking` since 2.1, which self-hosted Redis and SRH reject. keyLocking: false sends the scripts without the shebang (with their own precomputed hashes). Defaults to true.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2.1 every Lua script starts with the Upstash-only
#!lua flags=allow-key-lockingshebang, which self-hosted Redis / SRH reject, so users pin back to 2.0.8.Adds
keyLocking(defaulttrue) toRatelimitandMultiRegionRatelimit;keyLocking: falseruns the scripts without the shebang, using precomputed hashes for the stripped scripts. The docstring recommends leaving it on.Verified with new unit tests (
src/key-locking-flag.test.ts: stripped hashes match SHA1, evalsha/eval get the right hash/script for single and multi region) and the existing key-locking tests;hash.test.tsalso validates the stripped hashes against Redis. tsc/build errors insrc/analytics.tsare pre-existing on main.Linear: https://linear.app/upstash/issue/DX-3241/ratelimit-add-flag-to-disable-key-based-locking-with-enabled-by