Repository navigation
fix(hmget): preserve unsafe integers in HMGET, HGETEX and HGETDEL - #1485
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Route present hash fields through parseResponse so an integer JSON.parse cannot represent stays the original string. Null fields stay null. HGETEX and HGETDEL share this helper.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause.
HMGetCommandparsed each hash field withparseJSONand kept the number even when it could not be represented exactly. A stored9007199254740993came back as9007199254740992.HGETEXandHGETDELuse that same helper.HGETand the default command parser already return the original string for this case, viaparseResponse.Fix. Present fields now go through
parseResponse. A null field stays null. A leading BOM is still removed when the value parses cleanly, and remains on the original string when the integer would be rounded. The shared parser also keeps the original text whentoString()does not match it (a stored1.0stays"1.0"), which is howHGETalready behaves.Test.
hmget-deserialize.test.tscallsdeserializeonHMGET,HGETEXandHGETDELwith no Redis server. On main the four unsafe-integer cases fail. With this change all six tests pass, including null fields, ordinary JSON, the decimal1.5, a safe integer and a BOM-prefixed safe number. A changeset is included.Disclosure: this change was prepared with AI assistance.