Skip to content

Fix:(issue_2223) Fix incorrect processing of empty value after = #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dearchap merged 3 commits into from
Nov 16, 2025
+8 −1
Merged

Fix:(issue_2223) Fix incorrect processing of empty value after = #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51ee949
Merge pull request #2221 from malclocke/call-actions-on-env-flags-fro…
dearchap Nov 9, 2025
4012229
Merge branch 'main' of github.com:urfave/cli into main
dearchap Nov 16, 2025
2c77d6e
Fix:(issue_2223) Fix incorrect processing of =
dearchap Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion command_parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,12 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {

flagName := firstArg[numMinuses:]
flagVal := ""
valFromEqual := false
tracef("flagName:1 (fName=%[1]q)", flagName)
if index := strings.Index(flagName, "="); index != -1 {
flagVal = flagName[index+1:]
flagName = flagName[:index]
valFromEqual = true
}

tracef("flagName:2 (fName=%[1]q) (fVal=%[2]q)", flagName, flagVal)
Expand All @@ -162,7 +164,7 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {
tracef("processing non bool flag (fName=%[1]q)", flagName)
// not a bool flag so need to get the next arg
if flagVal == "" {
if len(rargs) == 1 {
if len(rargs) == 1 || valFromEqual {
return &stringSliceArgs{posArgs}, fmt.Errorf("%s%s", argumentNotProvidedErrMsg, firstArg)
}
flagVal = rargs[1]
Expand Down
5 changes: 5 additions & 0 deletions command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2727,6 +2727,11 @@ func TestFlagAction(t *testing.T) {
args: []string{"app", "--f_string="},
err: "flag needs an argument: --f_string=",
},
{
name: "flag_string_error2",
args: []string{"app", "--f_string=", "--f_bool"},
err: "flag needs an argument: --f_string=",
},
{
name: "flag_string_slice",
args: []string{"app", "--f_string_slice=s1,s2,s3"},
Expand Down