Skip to content

Fix(windows-test):display folder/request name properly and disable secondary sidebar - #155

Open
guru-sharan-bruno wants to merge 1 commit into
usebruno:mainfrom
guru-sharan-bruno:Test-windows-fix
Open

guru-sharan-bruno wants to merge 1 commit into
usebruno:mainfrom
guru-sharan-bruno:Test-windows-fix

Conversation

@guru-sharan-bruno

Copy link
Copy Markdown

Description

JIRA: VSCODE-158

This fix address the folder/request name displayed in the Windows and disables the secondary sidebar while an automation script is being executed in the VS Code extension.

Problem
Folder/request names were incorrectly displayed as (..) instead of showing the actual name.
The secondary sidebar remained visible while executing automation scripts.

Fix
Updated the folder/request name handling to display the correct name instead of (..).
Disabled the secondary sidebar during automation script execution in the VS Code extension.

…le secondary sidebar while executing automation script
return longPath.replace(/^([A-Za-z]):/, (_match, drive: string) => `${drive.toLowerCase()}:`);
}

async function ensureSecondarySidebarClosed(page: Page): Promise<void> {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if this is necessary and does affect the E2E meaningfully

if (!isVisible) return;

await page.keyboard.press('F1');
await page.waitForSelector('.quick-input-widget').catch(() => {});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add necessary timeouts.

const isVisible = await auxiliaryBar.isVisible().catch(() => false);
if (!isVisible) return;

await page.keyboard.press('F1');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the 'runCommand' @ tests/e2e/utils/page/actions.ts for the interaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants