fix: relativeDate shows "0 month ago" between 28 and 29 days - #77
Open
arpitjain099 wants to merge 1 commit into
Open
fix: relativeDate shows "0 month ago" between 28 and 29 days#77arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The weeks branch used weeksDifference < 4 (under 28 days), so 28 and 29 days elapsed fell through to the months branch where Math.floor(days / 30) is still 0, rendering '0 month ago'. Switch that branch to daysDifference < 30 so those days read '4 weeks ago' and the months branch is only used once at least one full month has passed. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notification timestamps use
relativeDate, and there's a small gap in its cascade. The weeks branch checksweeksDifference < 4, which stops at 28 days, but the months branch reportsMath.floor(daysDifference / 30), which is still 0 until day 30. So anything 28 or 29 days old renders as "0 month ago".The fix changes that branch to
daysDifference < 30so those two days read "4 weeks ago", and the months branch only kicks in once a full month has actually passed. Behavior for every other range is unchanged.I added a unit test in
src/webview/utils/common/relativeDate.spec.tscovering the seconds/minutes/hours/days/weeks/months cases plus the 28 and 29 day boundary;npx vitest runpasses (79 tests). Thanks for taking a look.