Skip to content

Conversation

@olivermrose
Copy link
Collaborator

Found when debugging #163

Also disables dragging on the anchor tags since those were in the way.

Copilot AI review requested due to automatic review settings December 11, 2025 23:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the rerendering behavior of the pinned channels group and prevents anchor tags from interfering with drag-and-drop operations. The fix addresses an issue discovered while debugging #163.

Key Changes:

  • Added draggable="false" to anchor tags in StreamTooltip to prevent interference with drag operations
  • Refactored Draggable component props from spread pattern to explicit Props interface for better type safety
  • Wrapped {#key} block around pinned channels to force rerender when pinned list length changes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/lib/components/StreamTooltip.svelte Added draggable="false" to anchor tag to prevent conflict with drag-and-drop functionality
src/lib/components/Draggable.svelte Refactored component to use explicit Props interface and removed unused type imports, passing id and index as functions to useSortable
src/lib/components/ChannelList.svelte Added {#key} block keyed on pinned array length to force recreation of draggable components when channels are added/removed from pinned list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@olivermrose olivermrose merged commit 2e7d457 into main Dec 11, 2025
8 checks passed
@olivermrose olivermrose deleted the fix/pinned-dupes branch December 11, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants