chore(deps): upgrade polar #253
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughBumped three dependencies in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
marble-api | 6fd476b | Dec 09 2025, 03:22 PM |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
apps/cms/package.json(2 hunks)
🔇 Additional comments (1)
apps/cms/package.json (1)
52-52: Confirm intent of pinned better-auth version.The
better-authdependency is pinned to1.4.0(without a caret^), unlike other dependencies. This is more restrictive and prevents automatic patch/minor updates. Confirm whether this intentional pinning is necessary or if it should use^1.4.0for consistency and to receive security patches.
…/upgrade-polar
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
apps/cms/package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-20T06:18:34.131Z
Learnt from: brandonmcconnell
Repo: usemarble/marble PR: 113
File: apps/cms/src/components/nav/page-header.tsx:0-0
Timestamp: 2025-08-20T06:18:34.131Z
Learning: When verifying Tailwind CSS syntax changes during upgrades, especially in large PRs, search more comprehensively across the entire codebase including packages/ directories, not just immediate files, as shared UI components may define group contexts and data attributes used across multiple applications.
Applied to files:
apps/cms/package.json
🔇 Additional comments (1)
apps/cms/package.json (1)
27-27: Version is current and valid.@polar-sh/sdk v0.41.5 is the latest version. ✓
| "@phosphor-icons/react": "^2.1.10", | ||
| "@polar-sh/better-auth": "^1.1.0", | ||
| "@polar-sh/sdk": "^0.41.1", | ||
| "@polar-sh/better-auth": "^1.6.0", |
There was a problem hiding this comment.
@polar-sh/better-auth version 1.6.0 does not exist—use 1.5.0 instead.
The latest published version of @polar-sh/better-auth is 1.5.0, not 1.6.0. This will cause npm install to fail with a version resolution error. Correct this to "^1.5.0".
🤖 Prompt for AI Agents
In apps/cms/package.json around line 26, the dependency "@polar-sh/better-auth":
"^1.6.0" references a non-existent version; change it to "^1.5.0" in the
dependencies block, save the file, and then run npm install (and update the
lockfile/commit the updated package-lock.json or yarn.lock) so the project can
resolve the correct published version.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/cms/src/lib/auth/auth.ts (1)
231-231: Replaceconsole.errorwith the project’s loggerThere’s a direct
console.errorcall in the error path for sending welcome emails; this conflicts with the shared TS/JS guideline to avoidconsolein application code. Consider routing this through your centralized logging/observability mechanism instead (e.g.logger.erroror similar), so logs are structured and consistently captured.As per coding guidelines, avoid
consoleusage in TypeScript/JavaScript files.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
apps/cms/package.json(2 hunks)apps/cms/src/lib/auth/auth.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/cms/package.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{ts,tsx,js,jsx}: Don't useaccessKeyattribute on any HTML element
Don't setaria-hidden="true"on focusable elements
Don't add ARIA roles, states, and properties to elements that don't support them
Don't use distracting elements like<marquee>or<blink>
Only use thescopeprop on<th>elements
Don't assign non-interactive ARIA roles to interactive HTML elements
Make sure label elements have text content and are associated with an input
Don't assign interactive ARIA roles to non-interactive HTML elements
Don't assigntabIndexto non-interactive HTML elements
Don't use positive integers fortabIndexproperty
Don't include "image", "picture", or "photo" in img alt prop
Don't use explicit role property that's the same as the implicit/default role
Make static elements with click handlers use a valid role attribute
Always include atitleelement for SVG elements
Give all elements requiring alt text meaningful information for screen readers
Make sure anchors have content that's accessible to screen readers
AssigntabIndexto non-interactive HTML elements witharia-activedescendant
Include all required ARIA attributes for elements with ARIA roles
Make sure ARIA properties are valid for the element's supported roles
Always include atypeattribute for button elements
Make elements with interactive roles and handlers focusable
Give heading elements content that's accessible to screen readers (not hidden witharia-hidden)
Always include alangattribute on the html element
Always include atitleattribute for iframe elements
AccompanyonClickwith at least one of:onKeyUp,onKeyDown, oronKeyPress
AccompanyonMouseOver/onMouseOutwithonFocus/onBlur
Include caption tracks for audio and video elements
Use semantic elements instead of role attributes in JSX
Make sure all anchors are valid and navigable
Ensure all ARIA properties (aria-*) are valid
Use valid, non-abstract ARIA roles for elements with ARIA roles
Use valid AR...
Files:
apps/cms/src/lib/auth/auth.ts
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: usemarble/marble PR: 0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-11-24T22:28:24.947Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use `node:assert/strict` over `node:assert`
Learnt from: CR
Repo: usemarble/marble PR: 0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-11-24T22:28:24.947Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Make sure all dependencies are correctly specified in React hooks
Learnt from: CR
Repo: usemarble/marble PR: 0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-11-24T22:28:24.947Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Ensure maximum type safety through strict configuration
Learnt from: CR
Repo: usemarble/marble PR: 0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-11-24T22:28:24.947Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Enforce strict type safety using Ultracite's linter and formatter
🔇 Additional comments (1)
apps/cms/src/lib/auth/auth.ts (1)
12-12: Import frombetter-auth/minimalis safeThe switch to
better-auth/minimalis verified as safe. The codebase has three remaining imports from"better-auth", but all are type-only imports (import type { User }), which don't affect runtime bundle size or tree-shaking. No runtime imports from the non-minimal entrypoint remain.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.