Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe component was refactored with typing and array handling improvements. The STACK_ORDER constant was changed from explicit string[] annotation to type inference with as const. The visibleMetrics variable received an explicit StackKey[] type annotation. Additionally, when no metrics are selected, visibleMetrics initialization was modified to return a shallow copy of STACK_ORDER instead of referencing the original array. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
visibleMetricsasStackKey[]Verification
Summary by cubic
Fix TypeScript types in the dashboard email chart to preserve literal metric keys and keep
visibleMetricstyped asStackKey[], avoiding implicit string indexing. No behavior change; resolves the compile error in thewebbuild.Written for commit c8be974. Summary will update on new commits.
Summary by CodeRabbit