Separated integers from rationals and added simple FastInteger wrapper - #751
Draft
Tomaqa wants to merge 4 commits into
Draft
Separated integers from rationals and added simple FastInteger wrapper#751Tomaqa wants to merge 4 commits into
FastInteger wrapper#751Tomaqa wants to merge 4 commits into
Conversation
Tomaqa
force-pushed
the
separate_integer
branch
2 times, most recently
from
August 22, 2024 07:18
a02c3cc to
5569e3c
Compare
Member
Author
|
I also corrected arithmetic operations s.t. they return |
Tomaqa
force-pushed
the
separate_integer
branch
2 times, most recently
from
August 23, 2024 14:42
64d1971 to
dd14374
Compare
Member
Author
|
I also experimented with a clearer distinction between |
Tomaqa
force-pushed
the
separate_integer
branch
from
August 23, 2024 14:45
dd14374 to
4584c81
Compare
Tomaqa
force-pushed
the
separate_integer
branch
2 times, most recently
from
November 4, 2024 18:54
1a2c4ad to
13adfbd
Compare
Tomaqa
marked this pull request as draft
November 5, 2024 11:46
Tomaqa
force-pushed
the
separate_integer
branch
4 times, most recently
from
November 7, 2024 15:12
a986a8a to
d347179
Compare
Tomaqa
force-pushed
the
separate_integer
branch
from
November 23, 2024 18:47
d347179 to
8187802
Compare
Tomaqa
force-pushed
the
separate_integer
branch
from
November 24, 2024 21:46
8187802 to
ff47abe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing
FastRationalclass contained some functions that are not related to rationals but to integers.I fixed this by making a derived class
FastIntegerand moving these specific functions there.