Repository navigation
[SEC] F-02: remove the updater sidecar and the Update button - #121
Merged
Merged
Conversation
The updater ran as root with the docker socket, a writable checkout and the host /tmp, and ran deploy.sh: compromise it, own the host. Updating is now only ./deploy/deploy.sh on the host. - compose (cloud and root): updater service, trigger volume and UPDATE_TRIGGER_DIR gone - deploy.sh: removes the retired updater container (by compose label) and its trigger volume; app and database are never named - app: no trigger/poll actions, no heartbeat reader; banner and Updates tab show the version and the command to run on the server (pt-BR and en) - docs and tests adjusted Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…command, in every runtime The source runtime still showed Update now / Force update and called runSourceUpdateAction, a server action that ran git pull, install, build and restart from the web process. Removed the action and the UI (and the strings and stale volume/Dockerfile notes that went with them). The page tells the version and the command to run on the server. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ustoppble
force-pushed
the
sec-updater
branch
from
November 4, 2026 21:47
15c42c0 to
13e562a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Audit finding F-02 (critical): the
updatersidecar ran as root, mounted/var/run/docker.sock, the writable checkout and the host/tmp, installed packages at boot and randeploy/deploy.sh. Compromise it and you own the host. Owner's decision: turn the button off; updating is onlycd /opt/overclick && ./deploy/deploy.shon the host.What goes
updaterservice,update-triggervolume andUPDATE_TRIGGER_DIRfromdeploy/docker-compose.cloud.ymlanddocker-compose.yml.triggerUpdateAction,readUpdaterStateAction, the heartbeat/status/trigger readers inlib/updates.ts,updaterEnableCommand, the Update button and its polling in the Updates tab and in the new-version banner, plus the i18n strings (pt-BR and en). No orphaned action or route is left; a test greps the app for the removed names.What the deploy does on the server
deploy.shremoves the oldupdatercontainer (found by its compose labels, never by touchingappor the db) before building, and afterup --remove-orphansremoves the leftoveroverclick_update-triggervolume only if no container uses it. App is recreated as on any deploy; the data volume is untouched. The first deploy of this change must run on the host, not from the old button (it would remove its own runner). Documented indeploy/README.md; quickstart users get--remove-orphanson their update command.Left as is (decision needed)
The source-checkout flow (
runSourceUpdateAction, update modeauto: git pull + pnpm install in the app's own process) does not use the sidecar and is not in F-02, so it stays. It is also an in-app update button, but only outside containers; say if it should go too.Verification
pnpm typecheck,pnpm build,pnpm test(web 1516 passed),scripts/test-deploy-project-files.sh(extended with the sidecar/volume cases).check:sheetneeds a live seeded board with a session; not run (unrelated to this diff).🤖 Generated with Claude Code