adds hugo teminal orange theme by fogine · Pull Request #277 · utterance/utterances

fogine · 2020-03-21T17:14:47Z

see hugo theme: https://github.com/panr/hugo-theme-terminal

Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Jeremy Danyow <jdanyow@gmail.com>

add my site Co-authored-by: Jeremy Danyow <jdanyow@gmail.com>

Co-authored-by: Jeremy Danyow <jdanyow@gmail.com>

jdanyow

theme is looking really good, left a few comments related to vendor prefixing and other small tweaks

jdanyow · 2020-03-22T18:49:41Z

src/stylesheets/themes/hugo-terminal-orange/index.scss

+  -moz-user-select: none;
+  -ms-user-select: none;
+  user-select: none;
+}


what is this rule for?

Do not know, I copied it from github-dark-orange theme. I deleted it and it seems to work fine without it.
Probably it disables styling on mobile devices.

jdanyow · 2020-03-22T18:51:49Z

src/stylesheets/themes/hugo-terminal-orange/index.scss

+
+body {
+  background-color: $bg-page;
+}


is this rule necessary? Thinking setting the $bg-page variable in variables.scss should have the same effect.

@jdanyow In my attempt to make it as compliant with other themes as possible, I copied github-dark-orange theme as a base and then edited it. So I'm not really sure :) Only thing I edited were variables as described in contribution section and button.scss.

body { background-color: $bg-page; } iframe { -webkit-touch-callout: none; -webkit-user-select: none; -khtml-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none; }

should be deleted from this file

jdanyow · 2020-03-22T18:53:18Z

src/stylesheets/themes/hugo-terminal-orange/placeholder.scss

+  ::-webkit-input-placeholder { @content; }
+  ::-moz-placeholder { @content; }
+  :-moz-placeholder { @content; }
+  :-ms-input-placeholder { @content; }


I think you can remove the prefixed versions of ::placeholder. Autoprefixer will add them as part of the scss build.

jdanyow · 2020-03-22T18:54:46Z

src/stylesheets/themes/hugo-terminal-orange/selection.scss

+@import "./variables";
+
+@mixin selection($element) {
+  #{$element}::-moz-selection { @content; }


autoprefixer will add the prefixed version of ::selection. Should be able to remove this line.

jdanyow · 2020-03-22T18:56:29Z

src/configuration-component.ts

        <option value="icy-dark">Icy Dark</option>
        <option value="dark-blue">Dark Blue</option>
        <option value="photon-dark">Photon Dark</option>
+        <option value="hugo-terminal-orange">Hugo Terminal Orange</option>


Could you move this directly beneath the github-dark-orange theme? Easier toggle between the two with the keyboard for comparison purposes.

fogine · 2020-03-22T19:31:50Z

@jdanyow, I made proposed changes to the theme.

fogine · 2020-04-07T09:19:03Z

ping @jdanyow

see hugo theme: https://github.com/panr/hugo-theme-terminal

jdanyow · 2020-11-14T20:53:17Z

please make the updates mentioned in the comments so I can merge

fogine · 2020-11-14T20:56:40Z

I did make them, dont you see? (like a year ago :) )

zsdycs

After modifying the above question, I think there is no problem with this "PR".

zsdycs · 2021-06-09T07:29:50Z

src/stylesheets/themes/hugo-terminal-orange/variables.scss

+$orange: rgb(255,168,106);
+$orange-200: #ffd1ac;
+$gray-000: #181818;
+$gray-100: #2B303B;/*comment header bg*/


There should be a space between the comment character and the comment content, for example:

/* comment header bg */

This is not required, but I recommend it.

zsdycs · 2021-06-09T07:31:44Z

tslint.json

-    "max-classes-per-file": [false],
+    "max-classes-per-file": false,
    "prefer-for-of": false,
    "no-implicit-dependencies": false


I think in this "PR", this file should not be modified. Because, even if it needs to be modified, it has nothing to do with the subject.

zsdycs · 2021-06-09T07:39:37Z

package.json

@@ -24,18 +24,18 @@
    "deploy": "gh-pages --dist dist"


This file should not be modified in this "PR".

zsdycs · 2021-06-09T07:39:42Z

SITES.md

@@ -89,3 +89,6 @@
 * [Tanel Poder's performance & troubleshooting blog](https://tanelpoder.com)


This file should not be modified in this "PR".

zsdycs · 2021-06-09T07:44:39Z

src/stylesheets/themes/github-dark-orange/index.scss

 @import "./placeholder.scss";
 @import "./combobox.scss";
 @import "./code.scss";
-


These codes should not be deleted. Because the current theme inherits the content of this theme.

So to set the background-color of body in your theme, you only need to set $bg-page in the variables.scss to the value you want.

zsdycs · 2021-06-09T07:46:38Z

src/stylesheets/themes/hugo-terminal-orange/heading.scss

@@ -0,0 +1,5 @@
+@import "./variables";
+
+h1, h2, h3, h4, h5, h6 {


After running, I think this setting has no effect.

h1, h2, h3, h4, h5, h6 will not have border

zsdycs · 2021-06-09T07:50:13Z

src/stylesheets/themes/hugo-terminal-orange/index.scss

+
+body {
+  background-color: $bg-page;
+}


body { background-color: $bg-page; } iframe { -webkit-touch-callout: none; -webkit-user-select: none; -khtml-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none; }

should be deleted from this file

zsdycs · 2021-06-09T07:52:03Z

yarn.lock

@@ -9,42 +9,43 @@
  dependencies:


This file should not be modified in this "PR".

fogine and others added 6 commits March 21, 2020 18:12

adds hugo teminal orange theme

b58789e

see hugo theme: https://github.com/panr/hugo-theme-terminal

add thepeachtimes to list (utterance#270)

1246a95

Efe Öge's blog is added. (utterance#271)

8507a0c

Co-authored-by: Jeremy Danyow <jdanyow@gmail.com>

Update SITES.md (utterance#272)

3f82fb4

add my site Co-authored-by: Jeremy Danyow <jdanyow@gmail.com>

add my website (utterance#274)

7963e89

Co-authored-by: Jeremy Danyow <jdanyow@gmail.com>

jdanyow requested changes Mar 22, 2020

View reviewed changes

jdanyow and others added 2 commits March 22, 2020 12:05

update deps (utterance#278)

4d9823c

css cleanup

89ed1de

fogine requested a review from jdanyow March 22, 2020 19:36

fogine added 3 commits April 14, 2020 20:27

adds hugo teminal orange theme

35cd606

see hugo theme: https://github.com/panr/hugo-theme-terminal

css cleanup

f81ca83

Merge branch 'master' of https://github.com/fogine/utterances

800d5c4

zsdycs reviewed Jun 9, 2021

View reviewed changes

		@@ -89,3 +89,6 @@
		* [Tanel Poder's performance & troubleshooting blog](https://tanelpoder.com)

		@@ -0,0 +1,5 @@
		@import "./variables";

		h1, h2, h3, h4, h5, h6 {

Conversation

fogine commented Mar 21, 2020

Uh oh!

jdanyow left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fogine Mar 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fogine Mar 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fogine commented Mar 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fogine commented Apr 7, 2020

Uh oh!

jdanyow commented Nov 14, 2020

Uh oh!

fogine commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zsdycs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fogine Mar 22, 2020 •

edited

Loading

fogine Mar 22, 2020 •

edited

Loading

fogine commented Mar 22, 2020 •

edited

Loading

fogine commented Nov 14, 2020 •

edited

Loading