fix: properly handle write errors for --version and --help output #10223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoNao89
force-pushed
the
fix/cat-version-help-dev-full-error
branch
from
8828b70 to
73af569
Compare
|
GNU testsuite comparison: |
- Modified ClapErrorWrapper to detect and report when printing --version/--help fails - Added test_version_help_dev_full to verify error handling - Fixes issue where cat --version > /dev/full silently succeeded instead of failing Addresses feedback from commit 9cc2e09
naoNao89
force-pushed
the
fix/cat-version-help-dev-full-error
branch
from
73af569 to
9da046c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where cat --version or cat --help would silently succeed when output fails, like when redirecting to /dev/full. Now the error wrapper properly detects write failures and reports them with appropriate exit codes.
@oech3's concern on commit 9cc2e09, where the original error handling change prevented panics but also silently ignored write failures for version and help output.