-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
tests/misc/coreutils.sh: Fail with invalid binary name #10258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
GNU testsuite comparison: |
e9b9baa to
ddd1f27
Compare
CodSpeed Performance ReportMerging this PR will improve performance by 6.49%Comparing Summary
Performance Changes
Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
src/bin/coreutils.rs
Outdated
| Some(OsString::from(util)) | ||
| } else { | ||
| // unmatched binary name => regard as multi-binary container and advance argument list | ||
| } else if binary_as_util.ends_with("coreutils") || binary_as_util.ends_with("box") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like to have .ends_with("box") in the binary just for test suite. Should be covered by shebang wrapper (at different PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shebang does not work...
572a08f to
a7da462
Compare
441d2a1 to
ff88392
Compare
Fixes #10244
Also covers some (but no all of) use case for symlinking binary to
/bin/false.