Skip to content

Conversation

@mattsu2020
Copy link
Contributor

Restore SIGPIPE signal to default disposition on Unix systems if not explicitly ignored by parent, ensuring proper pipeline behavior and GNU install compatibility. The Rust runtime ignores SIGPIPE by default, but this change respects the parent's signal settings for better script integration.

Restore SIGPIPE signal to default disposition on Unix systems if not explicitly ignored by parent, ensuring proper pipeline behavior and GNU install compatibility. The Rust runtime ignores SIGPIPE by default, but this change respects the parent's signal settings for better script integration.
Move the documentation comment for the main install utility function from above the SIGPIPE initialization to directly above the uumain function for better code organization and clarity.
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

Merging this PR will improve performance by 4.01%

⚡ 2 improved benchmarks
✅ 280 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory numfmt_large_numbers_si[10000] 4.9 MB 4.7 MB +4.01%
Memory du_wide_tree[(5000, 500)] 1.2 MB 1.2 MB +3.65%

Comparing mattsu2020:install_fix (9c6b037) with main (5fd3459)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Add "signals" to the uucore features list to support signal handling in the install utility, improving responsiveness to interrupts and system signals.
@Ecordonnier
Copy link
Collaborator

Ecordonnier commented Jan 16, 2026

Do you want to do this for each utility? I thought it's going to be needed in all utilities and would go to a central place?

@mattsu2020
Copy link
Contributor Author

Do you want to do this for each utility? I thought it's going to be needed in all utilities and would go to a central place?

Required for most utilities
Tee, yes, and watch require a different approach

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Jan 16, 2026

In theory we could add it to the bin macro but I do not know for sure if there are any utilities that should not have this behavior? Are either of you two aware of any non-standard niche pipe signal behavior in any of the utilities?

I was checking yes and I don't see how it has a unique implementation that's different than the other utilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants