Repository navigation
Add --list flag to multicall binary - #668
Merged
Merged
Conversation
sylvestre
reviewed
Oct 21, 2026
| let stdout = String::from_utf8(out.stdout).unwrap(); | ||
| let lines: Vec<&str> = stdout.lines().collect(); | ||
| assert!(!lines.is_empty()); | ||
| // Can be replaced with lines.is_sorted() starting with Rust 1.82. |
Contributor
There was a problem hiding this comment.
do we need this comment? :)
Contributor
Author
There was a problem hiding this comment.
Without it, someone will probably think, "this is silly, why don't we use is_sorted()?" then, change it and realize the rust version is too low. Having the comment let's us know when it's time to update this.
sylvestre
reviewed
Oct 21, 2026
Add a --list option that prints all registered utility names, one per line. This matches the existing convention in uutils/coreutils and enables scripts to dynamically discover available utilities without hardcoding lists. Update the usage text to document the new flag.
jmr
commented
Oct 21, 2026
| assert!(out.status.success()); | ||
| let stdout = String::from_utf8(out.stdout).unwrap(); | ||
| let lines: Vec<&str> = stdout.lines().collect(); | ||
| assert!(!lines.is_empty()); |
Contributor
Author
There was a problem hiding this comment.
This could fail if no features are enabled. Should I delete this or assume no one will test like that?
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a --list option that prints all registered utility names, one per line. This matches the existing convention in uutils/coreutils and enables scripts to dynamically discover available utilities without hardcoding lists.
Update the usage text to document the new flag.