Improved support for 'r' objects#183
Merged
Merged
Conversation
tolbrino
approved these changes
Sep 28, 2020
Collaborator
tolbrino
left a comment
tolbrino
left a comment
There was a problem hiding this comment.
I don't fully grasp the detailed differentiation between the types, but it looks consistent enough.
Accept review comments Co-authored-by: Tino Breddin <tolbrino@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR #163
Support for resource objects ('r') is made more general, and various inconsistencies around
update_counter()have been fixed, making it possible to use both names and resources as counters.Test cases added