Repository navigation
fix: restore multi-instance routing broken by Seerr v3.5.0 update - #30
Open
actuallyevan wants to merge 2 commits into
Open
actuallyevan wants to merge 2 commits into
actuallyevan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: What changed in Seerr v3.5.0
In Seerr v3.5.0 (PR #3385), status checks were added to
PUT /api/v1/request/:idandPOST /api/v1/request/:id/approve. Requests can only be modified or approved while inPENDINGstatus. Subsequent update or approval attempts return:Because Redirecterr handled multi-instance rules by updating and re-approving the same request ID in a loop, the first instance succeeded, but subsequent instances failed with a 409 error.
Solution
Redirecterr aligns with Seerr's dual-tier media model (separate request entities for standard vs. 4K media):
is_4kinstance configuration: Added an optionalis_4k: booleanproperty to instance definitions (defaults tofalse).POST /api/v1/requestwithis4k: true.seasons: [1, 2]or"all") when creating secondary series requests.Scope & Current Limitations
standardand4k), multi-instance routing is constrained to at most one standard and one 4K instance. Routing to 3+ instances or multiple instances of the same tier (e.g. two standard Radarrs) is rejected at startup.