chore(dev): clean up some allow statements

[WaterWhisperer]

Summary

clean up some allow(dead_code) statements now are unnecessary

Vector configuration

How did you test this PR?

cargo clippy and cargo test

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

Is this a breaking change?

• Yes
• No

Does this PR include user facing changes?

• Yes. Please add a changelog fragment based on our guidelines.
• No. A maintainer will apply the no-changelog label to this PR.

References

Related: #23659

Notes

• Please read our Vector contributor resources.
• Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
• Some CI checks run only after we manually approve them.
  • We recommend adding a pre-push hook, please see this template.
  • Alternatively, we recommend running the following locally before pushing to the remote branch:
    • make fmt
    • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
    • make test
• After a review is requested, please avoid force pushes to help us review incrementally.
  • Feel free to push as many commits as you want. They will be squashed into one before merging.
  • For example, you can run git merge origin master and git push.
• If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
  run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

[thomasqueirozb]

Hi @WaterWhisperer. This fails when running cargo check --tests --bin vector --no-default-features.
We have a check that runs for hours and that's why these allows are there. You can run it locally too: cargo vdev check component-features (again, this will take a long while). If I were testing that this change works for all features I'd start running with --no-default-features and the features that use that specific function and another feature that doesn't.

[WaterWhisperer]

Hi @WaterWhisperer. This fails when running cargo check --tests --bin vector --no-default-features. We have a check that runs for hours and that's why these allows are there. You can run it locally too: cargo vdev check component-features (again, this will take a long while). If I were testing that this change works for all features I'd start running with --no-default-features and the features that use that specific function and another feature that doesn't.

Thanks for the comments. I've solved and now can pass.

[thomasqueirozb]

Ran features check locally and these didn't pop up. Thanks!