fix(search): guard CrossEncoderReranker.ensure_initialized with asyncio.Lock#2445
Open
Srujan-rai wants to merge 1 commit into
Open
fix(search): guard CrossEncoderReranker.ensure_initialized with asyncio.Lock#2445Srujan-rai wants to merge 1 commit into
Srujan-rai wants to merge 1 commit into
Conversation
…io.Lock Two concurrent requests that both observed _initialized=False would both call initialize(), double-loading the local model and causing a memory spike. Added a lazily-created asyncio.Lock with double-checked locking so only the first caller runs initialization; subsequent callers wait and return immediately once _initialized=True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_initialized=Falsewould bothcall
initialize(), double-loading the local model and causing a memory spikeasyncio.Lockwith double-checked locking pattern soonly the first caller runs initialization; subsequent callers wait and return
immediately once
_initialized=TrueTests
Added
tests/test_reranker_init_lock.py:test_concurrent_ensure_initialized_calls_initialize_once— fires 3 concurrentensure_initialized()calls viaasyncio.gather, assertsinitializecalled oncetest_second_call_after_init_skips_initializesequential second call is a no-opTest plan