Skip to content

fix(consolidation): default missing dedup action to keep#2454

Merged
nicoloboschi merged 2 commits into
vectorize-io:mainfrom
koriyoshi2041:rios/dedup-missing-action-keep
Jun 30, 2026
Merged

fix(consolidation): default missing dedup action to keep#2454
nicoloboschi merged 2 commits into
vectorize-io:mainfrom
koriyoshi2041:rios/dedup-missing-action-keep

Conversation

@koriyoshi2041

Copy link
Copy Markdown
Contributor

Summary

  • default missing consolidation dedup decisions to keep
  • cover the underfilled structured-response path so a near twin is not merged unless the model explicitly returns action="merge"

Fixes #2453.

Tests

  • cd hindsight-api-slim && uv run pytest tests/test_consolidation_dedup.py -q
  • cd hindsight-api-slim && uv run ruff format --check hindsight_api/engine/consolidation/consolidator.py tests/test_consolidation_dedup.py
  • cd hindsight-api-slim && uv run ruff check hindsight_api/engine/consolidation/consolidator.py tests/test_consolidation_dedup.py
  • git diff --check

Note: local pre-commit did not complete because control-plane ESLint could not resolve @eslint/js; the focused checks above passed.

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Correct conservative fix: defaulting action to keep converts an underfilled structured response from a terminal ValidationError (which aborts the whole consolidation op) into the existing no-merge path. Minimal and right.

@nicoloboschi nicoloboschi merged commit 1c1cf4c into vectorize-io:main Jun 30, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(consolidation): _DedupDecision structured output fails when action is omitted

2 participants