-
Notifications
You must be signed in to change notification settings - Fork 261
[1.20.1] Add EMI compat. #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/1.3
Are you sure you want to change the base?
Conversation
|
In case there is no desire to merge this into FD, could this be a standalone addon instead? |
Absolutely! I'll make the addon. |
|
Any news on a potential addon to fix this? :D Farmers Delight is the only mod in my pack that does not show recipes in the crafting menu. |
Ive been busy lately and i want to wait on this PR's resolution before i put effort into that. |
# Conflicts: # gradle.properties
|
Thanks for moving the PR to the I wasn't sure whether to support another item viewer natively, due to maintenance, but after reading its docs to get more context for the PR, EMI seems pretty easy to manage. From the looks of it, the main new things to keep an eye on are:
I'll do some local testing, but everything here looks good for approval so far! |
Resolves #877
The main difficulty here was translating every tag, but ideally, you won't have to change the tags post 1.20.1.
Look at the 1.21 PR #972 to get a general idea of how difficult updating may be. EMI has a really good API, so I'd imagine it wouldn't be too painful, but ultimately, it's your call whether this gets in or not.