fix(slack): convert special mentions to readable text - #960
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Inbound `<!here>`, `<!channel>`, `<!everyone>` and `<!subteam^ID|@handle>` tokens were not converted by slackMrkdwnToMarkdown, so they stayed raw in message.text and parsed to an html node. Convert them to `@here`, `@channel`, `@everyone` and `@handle`, like `<@U…|name>` user mentions. Refs vercel#956 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Shubham Padkonde <shubhampadkonde12@gmail.com>
Contributor
|
@Shubham-Padkonde is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts inbound Slack special mentions to readable text, the special-mentions half of #956:
<!here>,<!channel>,<!everyone>(with or without a label) →@here,@channel,@everyone<!subteam^S…|@handle>→@handle, and<!subteam^S…>→@S…This follows the existing
<@U…|name>→@nameconversion inconvertSlackTokens, so the raw tokens no longer end up inmessage.textor parse to an mdasthtmlnode. The list half of #956 (building lists fromrich_text_listblocks) is not part of this PR.The table-cell test now expects
@S789instead of the raw<!subteam^S789>, since cell text goes through the same converter.Test plan
parseMessagetests; both fail before this change.vitest runinpackages/adapter-slack(793 tests),tsc --noEmit, andultracite checkon the changed files pass. I did not run the fullpnpm validate.Checklist
git commit -s)pnpm validatepasses🤖 Generated with Claude Code