Let a provider add document declarations and bind the indexing chain - #37796
Merged
sebastiannberg merged 5 commits intoSep 23, 2026
Merged
Conversation
sebastiannberg
force-pushed
the
sebastiannberg/commerce-discovery-declare-content
branch
from
September 4, 2026 11:19
76b4edf to
5e3fea8
Compare
sebastiannberg
marked this pull request as ready for review
September 4, 2026 11:19
gjoranv
approved these changes
Sep 7, 2026
gjoranv
reviewed
Sep 8, 2026
gjoranv
requested changes
Sep 8, 2026
sebastiannberg
force-pushed
the
sebastiannberg/commerce-discovery-declare-content
branch
from
September 21, 2026 13:09
5e3fea8 to
518449c
Compare
…on differing app declarations
Contributor
Author
|
thanks @gv, i have fixed your comments please take another look |
sebastiannberg
deleted the
sebastiannberg/commerce-discovery-declare-content
branch
September 23, 2026 06:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Follow-up to the commerce discovery schema provider: hosted Vespa can already add schemas to an application before the model is built. This lets the same provider also declare those schemas as document types in the content cluster, and bind an indexing chain it creates during model building.