Skip to content

feat: add iOS WeScan support and add more Android options - #62

Closed
romainboucher wants to merge 11 commits into
vicajilau:masterfrom
romainboucher:feat/add-android-features
Closed

feat: add iOS WeScan support and add more Android options#62
romainboucher wants to merge 11 commits into
vicajilau:masterfrom
romainboucher:feat/add-android-features

Conversation

@romainboucher

@romainboucher romainboucher commented Apr 17, 2024

Copy link
Copy Markdown

For iOS :

  • Allow multiple pages
  • Text localizations : English, French, ...
  • Update Readme
  • Customize colors : background and tint
  • Customize options : Automode, flash, gallery

For Android :

  • Customize ScannerMode (allow filter, base or full mode)
  • Allow / disallow auto mode

@romainboucher

Copy link
Copy Markdown
Author

@jachzen can you check this PR this please ? 😃

@romainboucher
romainboucher marked this pull request as draft April 18, 2024 08:07
@romainboucher romainboucher changed the title feat: add android scanner mode option feat: add iOS WeScan support and add more Android options Apr 18, 2024
@romainboucher

romainboucher commented Apr 18, 2024

Copy link
Copy Markdown
Author

#16
#57
#61

@romainboucher

Copy link
Copy Markdown
Author

@jachzen
jachzen marked this pull request as ready for review April 20, 2024 11:24
@jachzen

jachzen commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

@romainboucher thanks a lot for your work. i also started with wescan but couldn't find time to make progress. so thanks a lot for contributing. i will merge it in master. but i think the unittests are failing for now. maybe you can fix them.

@jachzen

jachzen commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

and i think it must be possible to add more than one image.

@jachzen
jachzen requested a review from vicajilau April 21, 2024 09:37
@romainboucher

Copy link
Copy Markdown
Author

and i think it must be possible to add more than one image.

ok, I'll add that in a few days.

@elmargro

Copy link
Copy Markdown

@romainboucher are you still on it?

@jachzen

jachzen commented May 13, 2024

Copy link
Copy Markdown
Collaborator

and i think it must be possible to add more than one image.

ok, I'll add that in a few days.

Hi Roman. Are still working on this ticket. otherwise i will finish it.

@romainboucher

Copy link
Copy Markdown
Author

sorry @jachzen, I don't have time at the moment. I think in a few weeks.

@ptantai

ptantai commented Aug 8, 2024

Copy link
Copy Markdown

Hi @jachzen Do you have time to finish this, i think Roman is quite busy with his own work. Thanks @jachzen !

@saileshbro

Copy link
Copy Markdown

hi @romainboucher, is there any way we can pass the file path of the image in memory and open the cropper only without letting user click image/select from gallery?

@lucasdidur

Copy link
Copy Markdown

@romainboucher Any updates on this?

@MbeleLebohang-uct

Copy link
Copy Markdown

Upvoting the importance of this PR.

1 similar comment
@abed-supy-io

Copy link
Copy Markdown

Upvoting the importance of this PR.

@abed-supy-io

Copy link
Copy Markdown

@romainboucher When are you expecting to finalize this ?

@FenyCz

FenyCz commented Dec 3, 2024

Copy link
Copy Markdown

Upvoting the importance of this PR.

1 similar comment
@velan3147

Copy link
Copy Markdown

Upvoting the importance of this PR.

@ndlinh-celtic

Copy link
Copy Markdown

@romainboucher
Please check PR romainboucher#1

@davidblanco-m

Copy link
Copy Markdown

Any update on this?

@elmargro

Copy link
Copy Markdown

@jachzen Will you be able to finish this PR?

@vicajilau

Copy link
Copy Markdown
Owner

WeScan has been archived as you can see here, so this will be dropped. Many thanks in advance

@vicajilau vicajilau closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.