Skip to content

fix(vidstack): handle fullscreen dispose rejection - #1798

Merged
mihar-22 merged 1 commit into
mainfrom
fix/1789-fullscreen-dispose-rejection
May 25, 2026
Merged

fix(vidstack): handle fullscreen dispose rejection#1798
mihar-22 merged 1 commit into
mainfrom
fix/1789-fullscreen-dispose-rejection

Conversation

@mihar-22

Copy link
Copy Markdown
Member

Summary

  • Make the fullscreen dispose handler synchronous.
  • Explicitly sink exit() rejections with void this.exit().catch(noop) during disposal.

Fixes #1789

Validation

  • pnpm --filter vidstack typecheck passed.
  • Initial validation attempt failed because the isolated worktree had no node_modules and tsgo was missing; installed dependencies with pnpm install --frozen-lockfile and reran successfully.

@mihar-22 mihar-22 changed the title fix: handle fullscreen dispose rejection fix(vidstack): handle fullscreen dispose rejection May 25, 2026
@mihar-22
mihar-22 marked this pull request as ready for review May 25, 2026 04:55
@mihar-22
mihar-22 merged commit bbb0f04 into main May 25, 2026
1 check passed
@mihar-22
mihar-22 deleted the fix/1789-fullscreen-dispose-rejection branch May 25, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Fullscreen #onDisconnect async not awaited causing unhandled rejection

1 participant