fix(vidstack): type legacy vite plugin - #1801
Merged
Merged
Conversation
mihar-22
marked this pull request as ready for review
May 25, 2026 04:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugintype.enforce: 'pre'value checked against Vite's plugin contract.Fixes #1792
Validation
pnpm install --frozen-lockfilesucceeded in the isolatedfix/1792-vite-enforce-typeworktree.pnpm exec tsgo -p tsconfig.json --noEmitfailed at the repository root with exit code 2 and 1035 diagnostic lines. The failures are broad existing root tsconfig issues: React TSX files are checked withoutjsx, Vitest globals are missing for test files, andpackages/vidstack/tsdown.config.tscannot findrolldowntypes. No diagnostics matchedpackages/vidstack/vite.config.ts,legacyPlugin, orenforce.cd packages/vidstack && pnpm exec tsgo -p tsconfig.json --noEmitpassed.