Skip to content

fix(vidstack): read slider intersection signal - #1811

Merged
mihar-22 merged 1 commit into
mainfrom
fix/1779-slider-intersection-signal
May 25, 2026
Merged

fix(vidstack): read slider intersection signal#1811
mihar-22 merged 1 commit into
mainfrom
fix/1779-slider-intersection-signal

Conversation

@mihar-22

Copy link
Copy Markdown
Member

Summary

  • Read the slider intersection signal value in #watchHidden instead of negating a bound function object.

Fixes #1779

Validation

  • pnpm --filter vidstack typecheck passed after installing dependencies with pnpm install --frozen-lockfile in the linked worktree.
  • Initial typecheck attempt failed because the new worktree had no node_modules and tsgo was missing locally.

@mihar-22 mihar-22 changed the title fix: read slider intersection signal fix(vidstack): read slider intersection signal May 25, 2026
@mihar-22
mihar-22 marked this pull request as ready for review May 25, 2026 04:55
@mihar-22
mihar-22 merged commit b1f546c into main May 25, 2026
1 check passed
@mihar-22
mihar-22 deleted the fix/1779-slider-intersection-signal branch May 25, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Slider #watchHidden uses .bind(this) on signal instead of calling it

1 participant