Skip to content

fix(vidstack): pass emptied event to notify - #1812

Merged
mihar-22 merged 1 commit into
mainfrom
fix/1778-html-emptied-event
May 25, 2026
Merged

fix(vidstack): pass emptied event to notify#1812
mihar-22 merged 1 commit into
mainfrom
fix/1778-html-emptied-event

Conversation

@mihar-22

@mihar-22 mihar-22 commented May 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Accept the native emptied event in #onEmptied.
  • Pass that event through to this.#ctx.notify("emptied", undefined, event).

Fixes #1778

Validation

  • pnpm --filter vidstack typecheck passed.
  • Initial typecheck attempt failed before dependency install because the new linked worktree had no node_modules and tsgo was not found; after pnpm install --frozen-lockfile, the requested command passed.

@mihar-22 mihar-22 changed the title fix: pass emptied event to notify fix(vidstack): pass emptied event to notify May 25, 2026
@mihar-22
mihar-22 marked this pull request as ready for review May 25, 2026 04:54
@mihar-22
mihar-22 merged commit 935ac43 into main May 25, 2026
1 check passed
@mihar-22
mihar-22 deleted the fix/1778-html-emptied-event branch May 25, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: #onEmptied references undefined event variable causing ReferenceError

1 participant