Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

Add Availability to change video rate #116

Open
MoElnaggar14 wants to merge 13 commits intovimeo:developfrom
MoElnaggar14:patch-1
Open

Add Availability to change video rate #116
MoElnaggar14 wants to merge 13 commits intovimeo:developfrom
MoElnaggar14:patch-1

Conversation

@MoElnaggar14
Copy link
Copy Markdown

@MoElnaggar14 MoElnaggar14 commented Mar 15, 2021

Ticket

TICKET_NUMBER

  • Note: this is required for Vimeo staff only. If not applicable to your PR, use "N/A".

Pull Request Checklist

  • Resolved any merge conflicts
  • No build errors or warnings are introduced
  • New public methods have Documentation

Issue Summary

Change Speed Rate of video #113

Implementation Summary

  • add setRate func in Player Protocol.
  • implement setRate func

Reviewer Tips

  • use setRate func to change the rate value of video.

@MoElnaggar14 MoElnaggar14 mentioned this pull request Mar 15, 2021
MoElnaggar14 and others added 11 commits March 16, 2021 19:07
- Add setOptimized() for configuring preferredForwardBufferDuration and preferredPeakBitRate
- Add setAsync() using Swift Concurrency to preload asset keys before playback
- Add preload() class method for warming up assets ahead of time
- Add preferredForwardBufferDuration and preferredPeakBitRate property passthroughs
- Bump minimum iOS to 16 to support modern async asset loading APIs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add playAtRate(_:) to start playback at desired rate atomically,
  avoiding the desync caused by separate play() + setRate() calls
- Fix seek completion handler to dispatch to main thread, preventing
  UI updates on background threads
- Add AVPlayerItemDidPlayToEndTime notification observer with
  playerDidFinishPlaying delegate callback
- Set audioTimePitchAlgorithm to .timeDomain for better audio quality
  at non-1x playback speeds
- Fix isMuted default from true to false (matching AVPlayer's default)
  and sync state on init

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant